Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix netlify doc links #188

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix netlify doc links #188

wants to merge 1 commit into from

Conversation

omnibs
Copy link

@omnibs omnibs commented May 14, 2024

Netlify deprecated automatic redirects of netlify.com (meant to host netlify-the-company content) to netlify.app (meant ot host netlify customer content). See: https://answers.netlify.com/t/deprecating-automatic-com-redirects/115442

The documentation links to netlify are now all broken :<

In this PR I just replaced netlify.com for netlify.app in this codebase.

  • ran tests locally with npm test <- didn't run bc just .md files
  • updated CHANGELOG.md if appropriate <- retroactively updated all netlify links there

ps: I didn't think this merited a new CHANGELOG entry, but lmk if you think it does!

Netlify deprecated automatic redirects of netlify.com (meant to host
netlify-the-company content) to netlify.app (meant ot host netlify
customer content). These links are now all broken :<

See:
https://answers.netlify.com/t/deprecating-automatic-com-redirects/115442
@omnibs
Copy link
Author

omnibs commented May 18, 2024

These failing netlify steps are not in CI.yml in the repo, right?

I tried pushing changes to it, but it doesn't seem to affect them.

@avh4
Copy link
Owner

avh4 commented Jun 16, 2024

Hmm, I tried to take a quick look, but I don't see where to figure out how netlify is configuring its environment.

I guess I'll try to move this to static webhosting to avoid letting netlify product changes break everything again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants